Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't run tests on DATABASE_URL #133

Open
michaelwood opened this issue Aug 7, 2020 · 1 comment
Open

Don't run tests on DATABASE_URL #133

michaelwood opened this issue Aug 7, 2020 · 1 comment

Comments

@michaelwood
Copy link
Collaborator

michaelwood commented Aug 7, 2020 •
edited
Loading

We ought to be running tests on a separate database to avoid any possibility of live data being deleted or changed by tests. Suggest we add TEST_DATABASE_URL and convert database.js to be an object that has an override on connection_pool to allow it to switch between using the different environment vars
@michaelwood
Copy link
Collaborator Author

a temporary solution is to add a "warning then sleep 5" to the delete database function to give people time to abort

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@michaelwood