From ad869213a6af8887f30b7644ff15ffee47f79e55 Mon Sep 17 00:00:00 2001 From: Omar Jaroudi <30807936+OmarJaroudi@users.noreply.github.com> Date: Fri, 18 Oct 2024 12:53:07 +0100 Subject: [PATCH] fix: disable sonarjs/deprecation in legacy preset --- legacy.js | 2 ++ 1 file changed, 2 insertions(+) diff --git a/legacy.js b/legacy.js index 79dd068..be8b607 100644 --- a/legacy.js +++ b/legacy.js @@ -73,6 +73,8 @@ module.exports = { "simple-import-sort/imports": "error", "simple-import-sort/exports": "error", "sort-destructure-keys/sort-destructure-keys": "error", + // Noisy rule - we may have helpers/methods that we mark as @deprecated but aren't planning to remove in the near future. This rule also significantly adds to eslint running time, which slows down both local development and CI. + "sonarjs/deprecation": "off", // This rule is not helpful in TypeScript files, and in JavaScript we often return different types from functions, so this is not a strictness level we want to enforce. "sonarjs/function-return-type": "off", // We may want to catch errors but not use the error object directly, just trigger error handling fallbacks within the catch block.