[DO NOT MERGE] Rename db|messaging|gen_ai.system to *.provider.name, rpc.system to rpc.protocol.name
#1613
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ider.name, pc.system to pc.protocol.name, feature_flag.system back to feature_flag.provider_name
lmolkova
commented
Nov 26, 2024
| - rename_attributes: | ||
| attribute_map: | ||
| feature_flag.provider_name: feature_flag.system |
There was a problem hiding this comment.
I'm going to extract it to another PR that we can merge right now to reduce churn in feature-flag area
lmolkova
force-pushed
the
rename-system-to-provider-name
branch
from
9da95a2
to
60daa8c
Compare
3 tasks
lmolkova
commented
Nov 26, 2024
| @@ -33,7 +33,6 @@ with the naming guidelines for RPC client spans. | |||
|
|
|||
| | Attribute | Type | Description | Examples | [Requirement Level](https://opentelemetry.io/docs/specs/semconv/general/attribute-requirement-level/) | Stability | | |||
| |---|---|---|---|---|---| | |||
| | [`rpc.system`](/docs/attributes-registry/rpc.md) | string | The value `aws-api`. | `aws-api` | `Required` |  | | |||
There was a problem hiding this comment.
I don't believe it's used correctly here
lmolkova
changed the title
db|messaging|gen_ai.system to *.provider.name, rpc.system to rpc.protocol.name, feature_flag.system back to feature_flag.provider_namedb|messaging|gen_ai.system to *.provider.name, rpc.system to rpc.protocol.name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1581
Warning
THIS IS A VERY-VERY-VERY BREAKING CHANGE (even though it affects experimental attributes only).
Backends use presence of these attributes as an indication that corresponding spans follow certain conventions.
*.provider.nameis*.provider.versionand similar in the future, especially when defining server-side conventionsThere used to bemoved to Renamefeature_flag.protocol_name, so we can't change it tofeature_flag.protocol.nameyet due to const name collision Implement code-generation hints to drop/rename attributes in case of a collision #1462feature_flag.systemback tofeature_flag.provider_name#1614rpc.protocol.nameis more precise for RPC where it captures different application-or-higher-level protocol that may work on top of another application protocol (grpc/thrift over http/2)Despite being problematic, we believe this change is necessary to accommodate future extension of semantic conventions for
*.system.*and this is the last chance to make this attribute name right before we declare any of these attributes stable.Merge requirement checklist
[chore]Given potentially high impact of this change and also upcoming holiday season, we'll need to keep it open for a while to collect the feedback