-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RabbitMQ: Specify how to populate messaging.destination.name
#1531
base: main
Are you sure you want to change the base?
RabbitMQ: Specify how to populate messaging.destination.name
#1531
Conversation
docs/messaging/rabbitmq.md
Outdated
- Otherwise: `amq.default` | ||
|
||
**Consumers** | ||
- `{exchange}:{routing key}:{queue}` when all values are present and non-empty. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe check if routing key and queue are the same and populate just one
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I looked and it seems when receiving/delivering, only the routing key is present https://www.rabbitmq.com/docs/consumers#message-properties. Also, if I understand it right from some research, the routing key can be then also the same as queue name https://stackoverflow.com/questions/22655735/retrieve-name-of-rabbitmq-queue-where-message-was-consumed-from
So I think you're right, we should be good to keep only the exchange and routing key. PTAL 69b8141
This PR was marked stale due to lack of activity. It will be closed in 7 days. |
Fixes #1529
Changes
Specify in more detail how to populate
messaging.destination.name
for RabbitMQ. I based it on the Default exchange docs. My understanding is that arouting key
is always present, even when using the default exchange (empty in this case). The routing key then is the queue name.For all other cases, I left it as
amq.default
which is what RabbitMQ uses. I saw reference for it for example here: https://www.rabbitmq.com/docs/access-controlMerge requirement checklist
[chore]