From f169f063e8bc9d2832eaf8d6882e1823dbf2d471 Mon Sep 17 00:00:00 2001 From: Tom Tan Date: Wed, 18 Dec 2024 14:00:50 -0800 Subject: [PATCH] Fix integration test and address feedback --- opentelemetry-otlp/tests/integration_test/tests/logs.rs | 2 +- opentelemetry-sdk/src/logs/log_processor.rs | 3 --- 2 files changed, 1 insertion(+), 4 deletions(-) diff --git a/opentelemetry-otlp/tests/integration_test/tests/logs.rs b/opentelemetry-otlp/tests/integration_test/tests/logs.rs index 8498a24913..b9810a7bbc 100644 --- a/opentelemetry-otlp/tests/integration_test/tests/logs.rs +++ b/opentelemetry-otlp/tests/integration_test/tests/logs.rs @@ -28,7 +28,7 @@ fn init_logs() -> Result { let exporter = exporter_builder.build()?; Ok(LoggerProvider::builder() - .with_batch_exporter(exporter, runtime::Tokio) + .with_batch_exporter(exporter) .with_resource( Resource::builder_empty() .with_service_name("logs-integration-test") diff --git a/opentelemetry-sdk/src/logs/log_processor.rs b/opentelemetry-sdk/src/logs/log_processor.rs index dd37af09ce..831ec1e522 100644 --- a/opentelemetry-sdk/src/logs/log_processor.rs +++ b/opentelemetry-sdk/src/logs/log_processor.rs @@ -1198,9 +1198,6 @@ mod tests { let exporter = InMemoryLogExporterBuilder::default().build(); let processor = BatchLogProcessor::new(Box::new(exporter.clone()), BatchConfig::default()); - // - // deadloack happens in shutdown with tokio current_thread runtime - // processor.shutdown().unwrap(); }