Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aggregation_temporality to be an enum #1742

Open
kaylareopelle opened this issue Oct 7, 2024 · 3 comments
Open

Update aggregation_temporality to be an enum #1742

kaylareopelle opened this issue Oct 7, 2024 · 3 comments

Comments

@kaylareopelle
Copy link
Contributor

kaylareopelle commented Oct 7, 2024

The aggregation_temporality option in the Sum and ExplicitBucketHistogram aggregations is currently open-ended. The only spec'd options for this are :delta and :cumulative. Let's update the assignment to use an enum instead.

Relates to #1555

Copy link
Contributor

github-actions bot commented Nov 7, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

@kaylareopelle
Copy link
Contributor Author

@xuan-cao-swi - I looked into this a little more after the SIG. The class I was thinking of as an example is is OpenTelemetry::Trace::Status. In the spec, the Set Status API only has three valid options. The class is used like this:

span&.status = Status.error("Unhandled exception of type: #{e.class}")

The class method is always called to get a valid status.

@arielvalentin, is something like this what you were initially thinking of when you recommended an enum for aggregation temporality or did you have something else in mind?

@xuan-cao-swi
Copy link
Contributor

Thanks for the example! I'd like to contribute on this based on the structure of OpenTelemetry::Trace::Status.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

2 participants