Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Determine when Metrics Views can be instantiated #1672

Open
kaylareopelle opened this issue Aug 7, 2024 · 1 comment
Open

Determine when Metrics Views can be instantiated #1672

kaylareopelle opened this issue Aug 7, 2024 · 1 comment

Comments

@kaylareopelle
Copy link
Contributor

This issue exists to further investigate the questions raised in this thread: https://github.com/open-telemetry/opentelemetry-ruby/pull/1604/files/749a8207ac07823be5a032b2b4703c2f7380dcd1#r1683589311

When initially testing views, I was creating the instrument first and then creating the view. However, when we refactored the code to reduce the number of times we needed to collect views for a particular instrument, this process changed. Now, views must be created first and instruments created after.

Questions

  • What do other languages do? Do they make the view and then the instrument?
  • How do they find the views performantly?
  • What does the spec say about adding views to instruments? Can a view be attached to an instrument at any time?
  • What makes sense at the instrumentation level? Does that impact ideas about instantiation?
Copy link
Contributor

github-actions bot commented Sep 7, 2024

👋 This issue has been marked as stale because it has been open with no activity. You can: comment on the issue or remove the stale label to hold stale off for a while, add the keep label to hold stale off permanently, or do nothing. If you do nothing this issue will be closed eventually by the stale bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To do
Development

No branches or pull requests

1 participant