Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Response success status validated incorrectly #4338

Open
slyapustin opened this issue Dec 5, 2024 · 0 comments · May be fixed by #4339
Open

Response success status validated incorrectly #4338

slyapustin opened this issue Dec 5, 2024 · 0 comments · May be fixed by #4339
Labels
bug Something isn't working

Comments

@slyapustin
Copy link

Describe your environment

OS: (e.g, Ubuntu)
Python version: (e.g., Python 3.8.10)
SDK version: (e.g., 1.25.0)
API version: (e.g., 1.25.0)

What happened?

There are some places, where success status of the request validated based on only 200 and 202 status code:

opentelemetry-python/exporter/opentelemetry-exporter-zipkin-json/src/opentelemetry/exporter/zipkin/json/__init__.py

Line 94 in 6812da2

REQUESTS_SUCCESS_STATUS_CODES = (200, 202)

opentelemetry-python/exporter/opentelemetry-exporter-zipkin-proto-http/src/opentelemetry/exporter/zipkin/proto/http/__init__.py

Line 91 in 6812da2

REQUESTS_SUCCESS_STATUS_CODES = (200, 202)

Steps to Reproduce

Receive the HTTP 204 succes status code

Expected Result

204 status to be treated as a success status

Actual Result

204 status code treated as an error

Additional context

Relevant issue (fixed) about the same behavior in another module: #3621

Would you like to implement a fix?

None
@slyapustin slyapustin added the bug Something isn't working label Dec 5, 2024
@slyapustin slyapustin linked a pull request Dec 5, 2024 that will close this issue
Open
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
1 participant
@slyapustin