New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logs SDK: consider renaming `LogRecordProcessor.emit` to `on_emit` #4312

Open

lmolkova opened this issue Nov 23, 2024 · 0 comments

Labels

logging

Contributor

lmolkova commented Nov 23, 2024

Existing definition:

opentelemetry-python/opentelemetry-sdk/src/opentelemetry/sdk/_logs/_internal/__init__.py

Line 276 in f639606

def emit(self, log_data: LogData):

Spec:

OnEmit is called when a LogRecord is emitted.

https://github.com/open-telemetry/opentelemetry-specification/blob/main/specification/logs/sdk.md#onemit

Related to open-telemetry/community#1751

emdneto added the logging label

emdneto added this to Python Logging API/SDK RC

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment