-
Notifications
You must be signed in to change notification settings - Fork 644
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add more rules to ruff
linter
#4227
Comments
Hi, |
@Neema-Joju If the issues are easy to fix, I think you can open a PR adding rule "A" with the actual fixes so we can get more coverage from Ruff Linter. |
@emdneto Ok. I'll create separate pull requests for different rules so, it will be easy for everyone to follow. As I work along I'll fix the issues that I can. |
The list of rules in the description are huge. Can we copy the most used rules from more modern projects from the ecosystem? Pydantic: https://github.com/pydantic/pydantic/blob/f9f4aee799ceb65b25b2f95a3c030b7df2e929d1/pyproject.toml#L190-L208 Also, related, but we can move away from pylint, like all modern projects? Since most of the rules are pedantic/redundant? |
@Kludex, sure. The description is just a list of rules to see what's more suitable for us; we don't need to implement all of them. Would you be open to sending a PR adding the rules? About pylint, I think we can drop pylint at some point when we are sure ruff is enough and we don't have pylint CI failing for a while |
Now we are using ruff, the idea is that we add more rules to ruff linter in separate PRs since there are a lot of fixes to do (maybe create a separate issues for that) . e.g.,
I think a good start would be to add support for:
ruff
ruleA
#4232)Originally posted by @emdneto in #4223 (comment)
The text was updated successfully, but these errors were encountered: