Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency jakarta.servlet:jakarta.servlet-api to v6 - autoclosed #1543

Closed

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 14, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
jakarta.servlet:jakarta.servlet-api (source) 5.0.0 -> 6.1.0 age adoption passing confidence

Release Notes

eclipse-ee4j/servlet-api (jakarta.servlet:jakarta.servlet-api)

v6.1.0

v6.0.0


Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot requested a review from a team as a code owner November 14, 2024 15:53
@renovate renovate bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch from cf275f6 to e68bc56 Compare November 18, 2024 19:18
@breedx-splk
Copy link
Contributor

breedx-splk commented Nov 18, 2024

cc @robsunday @SylvainJuge

The docs say that the minimum required java version for jakarta 6.1 is 17, and java 11 for jakarta 6.0....so I'm not entirely sure why it was ever working with java 8.

How important is testing with java 8 here? If it is important, then we should probably just pin jakarta to 5 or something.

@trask
Copy link
Member

trask commented Nov 19, 2024

we should probably just pin jakarta to 5 or something

we do this in the instrumentation repo:

https://github.com/open-telemetry/opentelemetry-java-instrumentation/blob/090fab2d649f69de00ec443f6ea52e54786f2d0c/.github/renovate.json5#L192-L197

@SylvainJuge
Copy link
Contributor

We used to need this Java 8 compatibility because the original wildfly server version used in integration tests was using it.

This is no longer the case, but keeping it java 8 compatible is very likely to be needed in the future when we test/add support for other application servers.

So while this is not needed and the application is simple enough that it won't make any difference, I think it's better to keep java 8 compatibility here. I am not familiar with renovate configuration though.

@SylvainJuge
Copy link
Contributor

I've opened #1554 with the needed changes to the renovate config bundled with another change that allows building on recent ARM-based MacOS systems.

@SylvainJuge
Copy link
Contributor

#1555 fixes the Java 8 compatibility issue, can you try to rebase this PR ?

I am not sure if renovate is aware of the Java language version when trying to update dependencies, if that's not the case then I'll re-open another PR to pin the servlet version dependency.

@renovate renovate bot force-pushed the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch from 0539482 to 9386291 Compare November 20, 2024 14:58
@SylvainJuge
Copy link
Contributor

Renovate does not seem to be aware of the java version compatibility here (which would have been surprising), so we still need to pin the servlet API version, I've opened #1558 for that.

@renovate renovate bot changed the title fix(deps): update dependency jakarta.servlet:jakarta.servlet-api to v6 fix(deps): update dependency jakarta.servlet:jakarta.servlet-api to v6 - autoclosed Nov 20, 2024
@renovate renovate bot closed this Nov 20, 2024
@renovate renovate bot deleted the renovate/jakarta.servlet-jakarta.servlet-api-6.x branch November 20, 2024 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants