-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(deps): update dependency jakarta.servlet:jakarta.servlet-api to v6 - autoclosed #1543
Conversation
cf275f6
to
e68bc56
Compare
The docs say that the minimum required java version for jakarta 6.1 is 17, and java 11 for jakarta 6.0....so I'm not entirely sure why it was ever working with java 8. How important is testing with java 8 here? If it is important, then we should probably just pin jakarta to 5 or something. |
we do this in the instrumentation repo: |
We used to need this Java 8 compatibility because the original wildfly server version used in integration tests was using it. This is no longer the case, but keeping it java 8 compatible is very likely to be needed in the future when we test/add support for other application servers. So while this is not needed and the application is simple enough that it won't make any difference, I think it's better to keep java 8 compatibility here. I am not familiar with renovate configuration though. |
I've opened #1554 with the needed changes to the renovate config bundled with another change that allows building on recent ARM-based MacOS systems. |
#1555 fixes the Java 8 compatibility issue, can you try to rebase this PR ? I am not sure if renovate is aware of the Java language version when trying to update dependencies, if that's not the case then I'll re-open another PR to pin the servlet version dependency. |
0539482
to
9386291
Compare
Renovate does not seem to be aware of the java version compatibility here (which would have been surprising), so we still need to pin the servlet API version, I've opened #1558 for that. |
This PR contains the following updates:
5.0.0
->6.1.0
Release Notes
eclipse-ee4j/servlet-api (jakarta.servlet:jakarta.servlet-api)
v6.1.0
v6.0.0
Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.