From bab246013bd7ee8d9844b77ec6aa49635252ee8c Mon Sep 17 00:00:00 2001 From: Damien Mathieu <42@dmathieu.com> Date: Wed, 27 Nov 2024 16:53:10 +0100 Subject: [PATCH] Fix span option typo in SDK span End, and WithAttributes only being available on span start (#6006) --- sdk/trace/span.go | 4 ++-- trace/config.go | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/sdk/trace/span.go b/sdk/trace/span.go index 15cd16a3254..8f4fc385082 100644 --- a/sdk/trace/span.go +++ b/sdk/trace/span.go @@ -438,8 +438,8 @@ func truncate(limit int, s string) string { // End ends the span. This method does nothing if the span is already ended or // is not being recorded. // -// The only SpanOption currently supported is WithTimestamp which will set the -// end time for a Span's life-cycle. +// The only SpanEndOption currently supported are [trace.WithTimestamp], and +// [trace.WithStackTrace]. // // If this method is called while panicking an error event is added to the // Span before ending it and the panic is continued. diff --git a/trace/config.go b/trace/config.go index 273d58e0014..9c0b720a4d6 100644 --- a/trace/config.go +++ b/trace/config.go @@ -213,7 +213,7 @@ var _ SpanStartEventOption = attributeOption{} // WithAttributes adds the attributes related to a span life-cycle event. // These attributes are used to describe the work a Span represents when this -// option is provided to a Span's start or end events. Otherwise, these +// option is provided to a Span's start event. Otherwise, these // attributes provide additional information about the event being recorded // (e.g. error, state change, processing progress, system event). //