Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option for default attributes to be included on http transport #5877

Closed
luca-filipponi opened this issue Jul 9, 2024 · 2 comments
Closed

Comments

@luca-filipponi
Copy link
Contributor

Currently, there is no option to include some default attributes for http transport metrics, custom attributes can only be added via the labeler in the request context.

If you want to create an http client and always include some attributes (for example the client name), you need to create a wrapper and add these attributes on a request basis.

I've made a draft pr to show how this could be done: #5876

@pellared
Copy link
Member

@luca-filipponi, why was it reopened?

@luca-filipponi
Copy link
Contributor Author

Probably just by mistake, didn't notice. Will close. Thanks @pellared!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants