Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add zerolog log bridge #5405

Closed
scorpionknifes opened this issue Apr 20, 2024 · 5 comments · Fixed by #5930
Closed

Add zerolog log bridge #5405

scorpionknifes opened this issue Apr 20, 2024 · 5 comments · Fixed by #5930
Assignees
@AkhigbeEromo
Labels
bridge: zerolog Related to the zerolog bridge enhancement New feature or request
Milestone
v1.29.0

Comments

@scorpionknifes
Copy link
Member

Add zerolog.Hook log bridge.

Another pretty popular log library, keen to work on this if we keen on this suggestion
@scorpionknifes scorpionknifes added the enhancement New feature or request label Apr 20, 2024
@scorpionknifes scorpionknifes changed the title Add zerologr log bridge Add zerolog log bridge Apr 21, 2024
@AkhigbeEromo
Copy link
Contributor

Hello @scorpionknifes , Can i work on this?

@scorpionknifes
Copy link
Member Author

👍 Feel free, I don't have permission to assign you tho.

Checkout for other bridge implementation
https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/bridges/otellogrus
https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/bridges/otelslog
https://github.com/open-telemetry/opentelemetry-go-contrib/tree/main/bridges/otelzap

This was referenced Jun 12, 2024
Closed
Merged
@domino14
Copy link

How's the progress on this @AkhigbeEromo ? Did you decide to take this on?

@AkhigbeEromo
Copy link
Contributor

Yes I did @domino14
Currently still working on it
Waiting for more reviews so I can make changes

dmathieu added a commit that referenced this issue Jul 11, 2024
@AkhigbeEromo @dmathieu @pellared
Add skeleton for zerolog bridge (#5782)
fb316b5 
This PR introduces the `otelzerolog` package, which provides a
`SeverityHook` to bridge the logging capabilities of Zerolog with
OpenTelemetry. The following key features are included:

## Changes

- Added `config` struct to handle configuration options.
- Implemented `Option` interface and related functions (`WithVersion`,
`WithSchemaURL`, `WithLoggerProvider`).
- Created `NewSeverityHook` function to initialize a `SeverityHook`.
- Defined `SeverityHook` struct to perform the logging bridge
functionality.

Part of
#5405

---------

Co-authored-by: Damien Mathieu <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
@AkhigbeEromo AkhigbeEromo mentioned this issue Jul 11, 2024
Merged
dmathieu added a commit that referenced this issue Jul 15, 2024
@AkhigbeEromo @MrAlias @dmathieu
added codeowners for zerolog bridge (#5905)
3fea6fd 
Added @dmathieu and @AkhigbeEromo as codeowners for the zerolog bridge
part of #5405

---------

Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Damien Mathieu <[email protected]>
@AkhigbeEromo AkhigbeEromo mentioned this issue Jul 16, 2024
Merged
MrAlias added a commit that referenced this issue Jul 17, 2024
@AkhigbeEromo @dmathieu
@pellared @MrAlias
zerolog: Hook implementation (#5918)
dedcf91 
part of #5405 
Implemented the run method and wrote tests for it

---------

Co-authored-by: Damien Mathieu <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
This was referenced Jul 17, 2024
Closed
Merged
dmathieu pushed a commit that referenced this issue Jul 19, 2024
@AkhigbeEromo
otelzerolog: Add benchmark (#5925)
47ee98d 
part of #5405
Added benchmark for zerolog
The result I got for the benchmark:

```
goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/contrib/bridges/otelzerolog
cpu: Intel(R) Core(TM) i5-6267U CPU @ 2.90GHz
BenchmarkHookRun-4   	  697216	      2059 ns/op	    1773 B/op	       0 allocs/op
PASS
ok  	go.opentelemetry.io/contrib/bridges/otelzerolog	3.110s
```
@AkhigbeEromo AkhigbeEromo mentioned this issue Jul 19, 2024
Merged
@dmathieu dmathieu linked a pull request Jul 22, 2024 that will close this issue
otelzerolog: Add otelzerolog under experimental bridge #5930
Merged
pellared added a commit that referenced this issue Jul 22, 2024
@AkhigbeEromo @pellared
otelzerolog: Add otelzerolog under experimental bridge (#5930)
68bd7f2 
Fixes #5405

---------

Co-authored-by: Robert Pająk <[email protected]>
@pellared pellared modified the milestone: v1.29.0 Jul 22, 2024
@pellared pellared added the bridge: zerolog Related to the zerolog bridge label Jul 22, 2024
@pellared
Copy link
Member

pellared commented Aug 8, 2024

The zerolog bridge has been not published.
Root cause: rs/zerolog#493
More: #5969

luca-filipponi pushed a commit to luca-filipponi/opentelemetry-go-contrib that referenced this issue Aug 9, 2024
@AkhigbeEromo @MrAlias
@dmathieu @luca-filipponi
added codeowners for zerolog bridge (open-telemetry#5905)
3ff3156 
Added @dmathieu and @AkhigbeEromo as codeowners for the zerolog bridge
part of open-telemetry#5405

---------

Co-authored-by: Tyler Yahn <[email protected]>
Co-authored-by: Damien Mathieu <[email protected]>
luca-filipponi pushed a commit to luca-filipponi/opentelemetry-go-contrib that referenced this issue Aug 9, 2024
@AkhigbeEromo @dmathieu
@pellared @MrAlias @luca-filipponi
zerolog: Hook implementation (open-telemetry#5918)
621b0df 
part of open-telemetry#5405 
Implemented the run method and wrote tests for it

---------

Co-authored-by: Damien Mathieu <[email protected]>
Co-authored-by: Robert Pająk <[email protected]>
Co-authored-by: Tyler Yahn <[email protected]>
luca-filipponi pushed a commit to luca-filipponi/opentelemetry-go-contrib that referenced this issue Aug 9, 2024
@AkhigbeEromo @luca-filipponi
otelzerolog: Add benchmark (open-telemetry#5925)
82e00b5 
part of open-telemetry#5405
Added benchmark for zerolog
The result I got for the benchmark:

```
goos: darwin
goarch: amd64
pkg: go.opentelemetry.io/contrib/bridges/otelzerolog
cpu: Intel(R) Core(TM) i5-6267U CPU @ 2.90GHz
BenchmarkHookRun-4   	  697216	      2059 ns/op	    1773 B/op	       0 allocs/op
PASS
ok  	go.opentelemetry.io/contrib/bridges/otelzerolog	3.110s
```
luca-filipponi pushed a commit to luca-filipponi/opentelemetry-go-contrib that referenced this issue Aug 9, 2024
@AkhigbeEromo @pellared @luca-filipponi
otelzerolog: Add otelzerolog under experimental bridge (open-telemetr…
c8739fe 
…y#5930)

Fixes open-telemetry#5405

---------

Co-authored-by: Robert Pająk <[email protected]>
@MrAlias MrAlias mentioned this issue Aug 23, 2024
Merged
MrAlias added a commit that referenced this issue Aug 23, 2024
@MrAlias
Release v1.29.0/v0.54.0/v0.23.0/v0.9.0/v0.4.0/v0.2.0/v0.1.0 (#6042)
fc25f67 
This release is the last to support [Go 1.21]. The next release will
require at least [Go 1.22].

### Added

- Add the `WithSpanAttributes` and `WithMetricAttributes` methods to set
custom attributes to the stats handler in
`go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc`.
(#5133)
- The `go.opentelemetry.io/contrib/bridges/otelzap` module. This module
provides an OpenTelemetry logging bridge for `go.uber.org/zap`. (#5191)
- Support for the `OTEL_HTTP_CLIENT_COMPATIBILITY_MODE=http/dup`
environment variable in
`go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp` to emit
attributes for both the v1.20.0 and v1.26.0 semantic conventions.
(#5401)
- The `go.opentelemetry.io/contrib/bridges/otelzerolog` module. This
module provides an OpenTelemetry logging bridge for
`github.com/rs/zerolog`. (#5405)
- Add `WithGinFilter` filter parameter in
`go.opentelemetry.io/contrib/instrumentation/github.com/gin-gonic/gin/otelgin`
to allow filtering requests with `*gin.Context`. (#5743)
- Support for stdoutlog exporter in
`go.opentelemetry.io/contrib/config`. (#5850)
- Add macOS ARM64 platform to the compatibility testing suite. (#5868)
- Add new runtime metrics to
`go.opentelemetry.io/contrib/instrumentation/runtime`, which are still
disabled by default. (#5870)
- Add the `WithMetricsAttributesFn` option to allow setting dynamic,
per-request metric attributes in
`go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#5876)
- The `go.opentelemetry.io/contrib/config` package supports configuring
`with_resource_constant_labels` for the prometheus exporter. (#5890)
- Support [Go 1.23]. (#6017)

### Removed

- The deprecated `go.opentelemetry.io/contrib/processors/baggagecopy`
package is removed. (#5853)

### Fixed

- Race condition when reading the HTTP body and writing the response in
`go.opentelemetry.io/contrib/instrumentation/net/http/otelhttp`. (#5916)

[Go 1.23]: https://go.dev/doc/go1.23
[Go 1.22]: https://go.dev/doc/go1.22
[Go 1.21]: https://go.dev/doc/go1.21
@pellared pellared closed this as not planned Won't fix, can't repro, duplicate, stale Oct 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@AkhigbeEromo AkhigbeEromo

Labels
bridge: zerolog Related to the zerolog bridge enhancement New feature or request
Projects
None yet
Milestone
v1.29.0
Development

Successfully merging a pull request may close this issue.

otelzerolog: Add otelzerolog under experimental bridge AkhigbeEromo/opentelemetry-go-contrib
4 participants
@domino14 @pellared @scorpionknifes @AkhigbeEromo