Add integration testing to the runtime instrumenation

[MrAlias]

Integration testing for the runtime instrumentation was removed in #2756

When open-telemetry/opentelemetry-go#3031 is resolved, a new runtime/test package need to be created and integration testing for the instrumentation added to it.

[jmacd]

Note that I don't think we should restore these tests, instead write new ones as described in #2624 and #2625. I've drafted such tests in https://github.com/lightstep/otel-launcher-go/tree/main/lightstep/instrumentation/runtime.

[MrAlias]

Blocked by open-telemetry/opentelemetry-go#3407

[MrAlias]

Unblocked. Use a manual-reader to collect expected metrics and the metricdatatest package to compare expected values (or just compare directly).

[MrAlias]

Blocked by:

• process.runtime.go.cgo.calls metric should be Counter #2648
• Rename or remove runtime.uptime metric from instrumentation/runtime package #2625
• Improvements to the instrumentation/runtime package #2624
• Runtime instrumentation: Make runtime.uptime an Asynchronous Gauge #1341
• runtime instrument type #368
• Runtime instrumentation: GC "total time spent" metric #316

[Victorsesan]

Can you assign this to me ?

[Victorsesan]

@dmathieu just wondering was open-telemetry/opentelemetry-go#3031 completely resolved for this issue?

[dmathieu]

Yes, the issue you mention is completely resolved.

However, the todo to add integration tests was removed in #5780. This PR does add an integration tests.
It has since then moved a bit, to

opentelemetry-go-contrib/instrumentation/runtime/runtime_test.go

Line 61 in bcaa646

func TestRuntimeWithLimit(t *testing.T) {

Which makes me think this issue got done in other PRs.

[Victorsesan]

@dmathieu I would love to contribute in another, if there are any "Good first issue" suitable for a novice like myself and which you can assign me to i would very much love to help. TIA

[dmathieu]

The good first issue tag has a few issues for newcomers.
Feel free to look at any open issue though.

[dmathieu]

Closing this, as I believe it has been done.