Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug] Mark instrumentation scope attributes as identifying #5859

Open
cijothomas opened this issue Sep 24, 2024 · 2 comments · May be fixed by #5982
Open

[bug] Mark instrumentation scope attributes as identifying #5859

cijothomas opened this issue Sep 24, 2024 · 2 comments · May be fixed by #5982
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package spec-compliance Issues related to compliance with the OpenTelemetry Specification
Milestone
Future

Comments

@cijothomas
Copy link
Member

Package

OpenTelemetry

Package Version

Package Name Version
OpenTelemetry.Api 1.8.0
OpenTelemetry 1.8.0
TBD TBD

Runtime Version

N/A

Description

Recently spec made scope tags as identifying. Only Metrics are affected today in this repo, but when we add Scope tags for Activitysource for .NET9, this should be considered.
open-telemetry/opentelemetry-specification#4161 (comment)

Steps to Reproduce

open-telemetry/opentelemetry-specification#4161 (comment) shows the unittest

Expected Result

make scope properties identifying

Actual Result

open-telemetry/opentelemetry-specification#4161 (comment)

Additional Context

No response
@cijothomas cijothomas added bug Something isn't working needs-triage New issues which have not been classified or triaged by a community member labels Sep 24, 2024
@github-actions github-actions bot added the pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package label Sep 24, 2024
@cijothomas
Copy link
Member Author

@rajkumar-rangaraj #5701 - Unsure if there is anything particular to be done for traces here. Most likely none.

@CodeBlanch CodeBlanch added this to the Future milestone Sep 30, 2024
@CodeBlanch CodeBlanch added spec-compliance Issues related to compliance with the OpenTelemetry Specification and removed needs-triage New issues which have not been classified or triaged by a community member labels Sep 30, 2024
@cijothomas cijothomas mentioned this issue Oct 16, 2024
Open
@cijothomas
Copy link
Member Author

For metrics, the change would be here: https://github.com/open-telemetry/opentelemetry-dotnet/blob/main/src/OpenTelemetry/Metrics/MetricStreamIdentity.cs#L139
It currently ignores Meter Tags, but it should be added now.
A unit test exist to validate current behavior, that should be modified to meet new spec.

@cijothomas cijothomas added help wanted Good for taking. Extra help will be provided by maintainers good first issue Good for newcomers labels Oct 23, 2024
@dulikvor dulikvor linked a pull request Nov 16, 2024 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working good first issue Good for newcomers help wanted Good for taking. Extra help will be provided by maintainers pkg:OpenTelemetry Issues related to OpenTelemetry NuGet package spec-compliance Issues related to compliance with the OpenTelemetry Specification
Projects
None yet
Milestone
Future
Development

Successfully merging a pull request may close this issue.

[bugFix] Meter tags are now recognized as identifiers dulikvor/opentelemetry-dotnet
2 participants
@cijothomas @CodeBlanch