-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(Dockerfile): set USER_GID alongside USER_UID #738
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should create a changelog for this because I'm not sure if this change can cause unexpected issues in some environments.
Is there any related documentation guidelines? I could not find any changelog file in the repo |
I think we use the autogenerated Github release notes in this repo. So no separate changelog necessary. |
would it not be better to add an actual collector changelog entry as a backport in the other repo(s)? This seems important enough to warrant that |
There is a changelog entry in the contrib v0.114.0 release https://github.com/open-telemetry/opentelemetry-collector-contrib/releases/tag/v0.114.0. The core collector does not have a container Dockerfile, maybe we could add a PR with just a changelog entry referencing this PR? |
Could we mention what kind of testing has been performed here? I'm mostly worried about any potential issues this can cause to existing users. I would expect that users using the upstream Helm charts and/or Operator to not be affected. @rogercoll is this verified? Based on the above ,+1 on surfacing this change as much as possible to the release notes. |
perfect
the core collector also has one but it's only in the releases repo. In any case, the dockerfile in the contrib repo is only used for testing and not for actual releases. The release dockerfiles are all in the releases repo. So I think it would also be good to have a changelog entry for the core collector just in a standalone PR. |
Fixes #662