Update GoReleaser templating to support all collector distros #708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackgopack4
changed the title
jackgopack4
commented
Nov 1, 2024
jackgopack4
commented
Nov 1, 2024
|
@TylerHelmuth I think you've worked with the goreleaser templating recently; would you or someone else mind taking a look? Thanks. |
|
@open-telemetry/helm-approvers @open-telemetry/operator-approvers appreciate some eyes on this change, thank you |
|
The templating changes look fine to me, but having them mixed with the PIE changes makes them harder to review. I'd prefer to merge #726 first. I also don't think we should proceed without @TylerHelmuth's review here. |
Agreed, removed those changes. |
TylerHelmuth
reviewed
Nov 6, 2024
TylerHelmuth
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #716 we do not currently generate the Goreleaser configurations for
otelcol-otlpandotelcol-k8sdue to different requirements in default files, configurations, builds, etc.This PR adds conditional logic to successfully generate these goreleaser templates.
Anyone can verify this change by downloading "main" branch, applying my changes to
Makefileandcmd/goreleaser/internal/configure.go, running$ make generate-goreleaserand see the minute formatting changes that get applied to the goreleaser templates.The pipeline tests should ensure that these binaries still build and release successfully but of course it should be verified after merge with v0.113.0 or v0.114.0
Updates to the goreleaser template will also likely be required to close #618 so I figured it was a good idea to get all four distros templated first