-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Host stability badges within otel ecosystem #298
Comments
cc @open-telemetry/docs-maintainers |
I'm not inherently opposed to hosting on the otel.io site, although I think it's more likely that we'd go down than sheilds.io would. |
Are the rate limits the major concern, are we hitting them on a regular basis? Based on the initial comment this is not for build pipelines etc, but for more or less static badges:
Our website is hosted on netlify, shields.io on cloudflare, so both should be fairly stable. Hosting it ourselves might add some extra control over caching I guess. Edit: An additional comment, if we choose between any option, then hosting those images within semconv is my least preferred, because with the copy of SemConv (https://opentelemetry.io/docs/specs/semconv/) on the website they would land on opentelemetry.io eventually anyway |
yes, looks like caching is solving most of the concerns. And, as long as you keep an alternate title for each badge I don't see any issues even if whatever service is used is down. |
I'm going to close it since caching takes care of things and we don't see any problems after enabling badges everywhere. |
From #278 (comment)
shields.io is designed to provide badges for things like GitHub pipeline status, it's cached by the browser, by the GH and on the shields.io content distribution side.
But it's an external dependency, which might go down or degrade, we might hit rate-limits affecting anyone browsing semconvs.
As an immediate mitigation we can disable badge generation in favor of plain text, but in the long term we should consider hosting badges ourselves:
The text was updated successfully, but these errors were encountered: