-
-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TODO] support sample weights when training #256
Comments
This is probably going to improve things for end-user but when we update our Anki and optimise, this should result in worse log-loss in which Anki will just retain the previous parameters instead of updating them. Wdyt about that? |
Maybe we need apply the weights in the evaluation, too. |
I've said this before - if we apply weights during both evaluation and training, then loss values will effectively become arbitrary since they depend on the weighting function. |
It will make these possible:
fsrs-optimizer has supported it: open-spaced-repetition/fsrs-optimizer#152
The text was updated successfully, but these errors were encountered: