Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix uncrustify tests for humble #68

Open
orensbruli opened this issue Sep 10, 2022 · 1 comment
Open

Fix uncrustify tests for humble #68

orensbruli opened this issue Sep 10, 2022 · 1 comment
Labels
bug Something isn't working

Comments

@orensbruli
Copy link
Contributor

Bug report

Looks like a minor uncrustify discrepancy:
https://github.com/open-rmf/rmf_task/runs/8285620339?check_suite_focus=true#step:5:1738

Required information:

  • Operating system and version:
    • jammy
  • OpenRMF installation type:
    • source
  • ROS distribution and version:
    • humble
  • ROS installation type:

Description of the bug

https://github.com/open-rmf/rmf_task/runs/8285620339?check_suite_focus=true#step:5:1738

  2: --- src/rmf_task/TaskPlanner.cpp
  2: +++ src/rmf_task/TaskPlanner.cpp.uncrustify
  2: @@ -541 +541,2 @@
  2: -        return {};
  2: +        return {}
  2: +      ;

Steps to reproduce the bug

Reproducible in CI runs. No tested in local.

Expected behavior

Tests pass.

Actual behavior

Test fails

@orensbruli orensbruli added the bug Something isn't working label Sep 10, 2022
@orensbruli orensbruli changed the title Fix tests for humble Fix uncrustify tests for humble Sep 10, 2022
@orensbruli
Copy link
Contributor Author

I think I found an issue related to this:
uncrustify/uncrustify#3191

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant