Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consider making EstimateCache an opaque object #2

Open
mxgrey opened this issue Mar 24, 2021 · 0 comments
Open

Consider making EstimateCache an opaque object #2

mxgrey opened this issue Mar 24, 2021 · 0 comments
Labels
quality Improvements to quality, e.g. performance, usability, stability

Comments

@mxgrey
Copy link
Contributor

mxgrey commented Mar 24, 2021

API Quality Request

The EstimateCache class is passed around by the public API, but as far as I can tell it only gets used by internal mechanisms of rmf_task. To reduce the surface area of the public API that we need to maintain stability for, we should consider making EstimateCache an opaque class, similar to CostCalculator.
@mxgrey mxgrey added the quality Improvements to quality, e.g. performance, usability, stability label Mar 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
quality Improvements to quality, e.g. performance, usability, stability
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mxgrey