Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow installing optional dependencies easily with pip #361

Closed
jonc125 opened this issue Sep 7, 2017 · 4 comments
Closed

Allow installing optional dependencies easily with pip #361

jonc125 opened this issue Sep 7, 2017 · 4 comments
Milestone

Comments

@jonc125
Copy link

jonc125 commented Sep 7, 2017

Given there are constraints on (e.g.) the version of Django to use with Sumatra, it'd be nice to be able to do say pip install sumatra[django,git] and get the correct dependencies for working with the front-end and git repositories.

@timtroendle
Copy link
Contributor

For Django this should always be the case when you pip install: Django is a mandatory dependency, and a compatible version will be installed should you not have any. You can always install optional dependencies with, for example, pip install sumatra[git] to install latest versions. Are there any concrete compatibility issues you are facing?

@jonc125
Copy link
Author

jonc125 commented Sep 7, 2017

I did pip install sumatra django and got Django 1.11 installed...

@timtroendle
Copy link
Contributor

I see and can reproduce. That's odd. It's not necessary to mention django explicitly though, and weirdly if you don't, it works: pip install sumatra will install Django 1.8. So with sumatra already installed you should be able to fix it with:

pip uninstall sumatra
pip install sumatra

It's unclear to me why pip installs an incompatible version when you mention it explicitly. I don't use pip a lot, so can't tell you what's going wrong. Maybe one of the other contributors can?

@apdavison apdavison modified the milestone: 0.8 Sep 10, 2017
@apdavison
Copy link
Contributor

I'm almost certain this is a problem with pip, not with Sumatra. As @timtroendle said, just pip install sumatra should automatically give you the correct version of Django.

(Note that updating Sumatra to work with the most recent Django is on my list of short-term plans - see #366)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants