-
Notifications
You must be signed in to change notification settings - Fork 95
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mismatched hybrid default OIDs #520
Comments
Thanks for this report. The markdown file should be generated by what is in generate.yml. If it is not, we've got a serious problem indeed (I didn't check this any more assuming this to be OK since a long time). Thanks also for reporting your work on interop testing: This is very helpful for everyone and I cannot imagine the BouncyCastle team not being interested in this given the alignment between OpenSSL and BouncyCastle.. |
After a quick glance before I have to hit the road, the problem is not so bad: The logic generating random OIDs seems to be not working OK. The problem can be easily resolved if one were to add OIDs for all algorithms to |
That's what's now happening if #522 lands. Albeit "bomb" is too strong a word -- a normal |
It seems to me that there is a discrepancy between the default OIDs of hybrid algorithms listed in the
ALGORITHMS.md
file and the actual default OIDs assigned inoqsprov/oqsprov.c
. For example, the markdown file says thatp384_mlkem768
has the default OID1.3.9999.99.75
, while it is actually assigned the1.3.9999.99.31
OID. I found quite a few of these, but didn't bother checking all of them. Am I missing something or should they be the same?Btw I found these while writing interop tests between oqs-provider and a hybridization PR I opened to the C# bouncy castle repo. I haven't yet received any feedback if they are actually open to merging something like this.
The text was updated successfully, but these errors were encountered: