Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

liboqs "standard" branch: YML format breakage #261

Closed
baentsch opened this issue Sep 21, 2023 · 2 comments
Closed

liboqs "standard" branch: YML format breakage #261

baentsch opened this issue Sep 21, 2023 · 2 comments

Comments

@baentsch
Copy link
Member

When adding the "standard" pqcrystals code into oqsprovider the documentation generator logic failed as the previously int field "nist-round" has been changed to a string in this branch:

https://github.com/open-quantum-safe/liboqs/blob/3cca41957593db65b5acf6da772f28fa7ede2aa3/docs/algorithms/kem/kyber.yml#L17

Error triggered here.

We may also move this issue to oqsprovider, @bhess, if you agree it is one and should be fixed -- unsure whether there or here, though.

@praveksharma : Please decide whether you'd need proper (O)ID documentation for the interop event. If so, this issue needs to be resolved to properly create it. Otherwise, please review/approve/merge #260 to use the oqsprovider "interop-test" branch at the IETF event(s).

@bhess
Copy link
Member

bhess commented Sep 21, 2023

If allowing a string isn't an issue beyond parsing, I'd tend to update the parser in oqs-provider.

@baentsch baentsch transferred this issue from open-quantum-safe/liboqs Sep 21, 2023
@baentsch baentsch changed the title "standard" branch: YML format breakage liboqs "standard" branch: YML format breakage Sep 21, 2023
@baentsch
Copy link
Member Author

If allowing a string isn't an issue beyond parsing, I'd tend to update the parser in oqs-provider.

Done in e6de3ff

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants