Help needed regarding public/private portion of EVP_PKEY structure used for encoding #349
Replies: 1 comment 4 replies
-
|
I'm not sure what you're asking of us: This feels a bit like you're asking us to debug your code:
To reduce the amount of code we need to understand, can I ask you to formulate the issue by way of a bug report with the minimal amount of code needed to show dubious behaviour (of course also referencing the relevant documentation)? Alternatively, highlight the modifications to our code and explain the rationale for those modifications. |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the response, let me try to rephrase my query. Bets regards |
Beta Was this translation helpful? Give feedback.
-
|
Thanks for the textual description of what you're trying to check, @umairsafdar768 : That helped me understand your goal. Yes, we share a common understanding here.
If this is the only addition to the test (? is it? I thus prefer diffs over long code snippets) then this wouldn't cut it as the tests run over several structs, some without, but also some with private key, see oqs-provider/test/oqs_test_endecode.c Lines 36 to 50 in 81eae6d I absolutely don't want to rule out there's something fishy based on your description, but what would help us most to get to the bottom of this would be a (separate? parameterized?) test case for this: If you'd be willing to do that (?), I'd gladly review it in the form of a PR -- and if it documents an error, even better -- that would (after fixing :) make the whole system better. |
Beta Was this translation helpful? Give feedback.
-
No its not the only addition. I'll share a diff of my modifications.
Yes, I am aware of that, and one of the modifications to the test is; using only the last element of this array Below you can see the diff: diff --git a/test/oqs_test_endecode.c b/test/oqs_test_endecode.c
index 1427d12..3484816 100644
--- a/test/oqs_test_endecode.c
+++ b/test/oqs_test_endecode.c
@@ -49,7 +49,33 @@ static ENDECODE_PARAMS test_params_list[] = {
{"DER", "SubjectPublicKeyInfo", NULL, NULL,
OSSL_KEYMGMT_SELECT_PUBLIC_KEY | OSSL_KEYMGMT_SELECT_ALL_PARAMETERS},
};
-
+//dependencies from "test_common.c"
+#define MIN(X, Y) (((X) < (Y)) ? (X) : (Y))
+int alg_is_enabled(const char *algname)
+{
+ char *alglist = getenv("OQS_SKIP_TESTS");
+ char *comma = NULL;
+ char totest[200];
+
+ if (alglist == NULL)
+ return 1;
+
+ while ((comma = strchr(alglist, ','))) {
+ memcpy(totest, alglist, MIN(200, comma - alglist));
+ totest[comma - alglist] = '\0';
+ if (strstr(algname, totest))
+ return 0;
+ alglist = comma + 1;
+ }
+ return strstr(algname, alglist) == NULL;
+}
+void load_oqs_provider(OSSL_LIB_CTX *libctx, const char *modulename,
+ const char *configfile)
+{
+ T(OSSL_LIB_CTX_load_config(libctx, configfile));
+ T(OSSL_PROVIDER_available(libctx, modulename));
+}
+//dependencies end
static EVP_PKEY *oqstest_make_key(const char *type, EVP_PKEY *template,
OSSL_PARAM *genparams)
{
@@ -172,23 +198,23 @@ static int test_oqs_encdec(const char *alg_name)
BUF_MEM *encoded = NULL;
size_t i;
int ok = 0;
-
- for (i = 0; i < nelem(test_params_list); i++) {
+
+ //for (i = 0; i < nelem(test_params_list); i++) {
pkey = oqstest_make_key(alg_name, NULL, NULL);
if (pkey == NULL)
goto end;
-
- if (!encode_EVP_PKEY_prov(pkey, test_params_list[i].format,
- test_params_list[i].structure,
- test_params_list[i].pass,
- test_params_list[i].selection, &encoded)) {
+ //only using Public portion of keypair in encoding -> 6th element of test_params_list array
+ if (!encode_EVP_PKEY_prov(pkey, test_params_list[5].format,
+ test_params_list[5].structure,
+ test_params_list[5].pass,
+ test_params_list[5].selection, &encoded)) {
printf("Failed encoding %s", alg_name);
goto end;
}
if (!decode_EVP_PKEY_prov(
- test_params_list[i].format, test_params_list[i].structure,
- test_params_list[i].pass, test_params_list[i].keytype,
- test_params_list[i].selection, &decoded_pkey, encoded->data,
+ test_params_list[5].format, test_params_list[5].structure,
+ test_params_list[5].pass, test_params_list[5].keytype,
+ test_params_list[5].selection, &decoded_pkey, encoded->data,
encoded->length)) {
printf("Failed decoding %s", alg_name);
goto end;
@@ -198,13 +224,27 @@ static int test_oqs_encdec(const char *alg_name)
printf("Key equality failed for %s", alg_name);
goto end;
}
+ //private key existance check
+ EVP_PKEY_CTX *actx = NULL;
+ if ((actx = EVP_PKEY_CTX_new_from_pkey(keyctx, decoded_pkey, NULL)) == NULL){
+ fprintf(stderr, cRED " EVP_PKEY_CTX_new_from_pkey failure" cNORM "\n");
+ goto end;
+ }
+ if(EVP_PKEY_private_check(actx)==1){
+ printf("Private Key yes!\n");
+ goto end;
+ }
+ else{
+ printf("no private key\n");
+ }
+
EVP_PKEY_free(pkey);
pkey = NULL;
EVP_PKEY_free(decoded_pkey);
decoded_pkey = NULL;
BUF_MEM_free(encoded);
encoded = NULL;
- }
+ //}
ok = 1;
end:
EVP_PKEY_free(pkey);
@@ -216,19 +256,18 @@ end:
static int test_algs(const OSSL_ALGORITHM *algs)
{
int errcnt = 0;
- for (; algs->algorithm_names != NULL; algs++) {
- if (test_oqs_encdec(algs->algorithm_names)) {
+ //only checking one algorithm -> kyber512
+ //for (; algs->algorithm_names != NULL; algs++) {
+ if (test_oqs_encdec("kyber512")) {
fprintf(stderr,
- cGREEN " Encoding/Decoding test succeeded: %s" cNORM "\n",
- algs->algorithm_names);
+ cGREEN " Encoding/Decoding test succeeded for Kyber512" cNORM "\n");
} else {
fprintf(stderr,
- cRED " Encoding/Decoding test failed: %s" cNORM "\n",
- algs->algorithm_names);
+ cRED " Encoding/Decoding test failed for Kyber512" cNORM "\n");
ERR_print_errors_fp(stderr);
errcnt++;
}
- }
+ //}
return errcnt;
}
@@ -240,9 +279,10 @@ int main(int argc, char *argv[])
const OSSL_ALGORITHM *algs;
T((libctx = OSSL_LIB_CTX_new()) != NULL);
- T(argc == 3);
- modulename = argv[1];
- configfile = argv[2];
+ //specifying modulename and configfile here instead of taking as arguments
+ //T(argc == 3);
+ modulename = "oqsprovider";
+ configfile = "/home/ros2/diff-oqs/oqs.cnf";
load_oqs_provider(libctx, modulename, configfile);
@@ -253,19 +293,20 @@ int main(int argc, char *argv[])
dfltprov = OSSL_PROVIDER_load(keyctx, "default");
keyprov = OSSL_PROVIDER_load(keyctx, modulename);
oqsprov = OSSL_PROVIDER_load(libctx, modulename);
-
- algs = OSSL_PROVIDER_query_operation(oqsprov, OSSL_OP_SIGNATURE,
- &query_nocache);
-
- if (algs) {
- errcnt += test_algs(algs);
- } else {
- fprintf(stderr, cRED " No signature algorithms found" cNORM "\n");
- ERR_print_errors_fp(stderr);
- errcnt++;
- }
-
-#ifdef OQS_KEM_ENCODERS
+
+ //disabling signature algorithm check
+ // algs = OSSL_PROVIDER_query_operation(oqsprov, OSSL_OP_SIGNATURE,
+ // &query_nocache);
+
+ // if (algs) {
+ // errcnt += test_algs(algs);
+ // } else {
+ // fprintf(stderr, cRED " No signature algorithms found" cNORM "\n");
+ // ERR_print_errors_fp(stderr);
+ // errcnt++;
+ // }
+//only checking kem algorithm
+//#ifdef OQS_KEM_ENCODERS
algs = OSSL_PROVIDER_query_operation(oqsprov, OSSL_OP_KEM, &query_nocache);
if (algs) {
@@ -275,7 +316,7 @@ int main(int argc, char *argv[])
ERR_print_errors_fp(stderr);
errcnt++;
}
-#endif /* OQS_KEM_ENCODERS */
+//#endif /* OQS_KEM_ENCODERS */
OSSL_PROVIDER_unload(dfltprov);
OSSL_PROVIDER_unload(keyprov);In an Ubuntu 22.04 system with openssl 3.2.0 and liboqs 0.8.0 and oqs-provider 0.5.2 installed in default locations (/usr/local), the following can be used to compile the above modified C file: The expected behavior (based on above diff) is that since only public portion of key pair is being encoded, the
But the actual behavior is that the function
is printed as output of the compiled program.
Yes I am surely willing to do that. Will a modified Thanks, |
Beta Was this translation helpful? Give feedback.
-
Thanks for your willingness to do that. The specific requirement for any PR is that it refers to the current "main" branch, does not contain references to specific, unknown config files ("/home/ros2/diff-oqs/oqs.cnf" in the diff) or any other hard coded constants. In this case, I'd figure some All that said, I wonder what exactly entails "validation" in the OpenSSL spec for EVP_PKEY_private_check? Do you have any information what this means (particularly outside the realm of a FIPS provider)? Have you tried to execute |
Beta Was this translation helpful? Give feedback.
-
Hello,
I have been playing around with the different tests that are included with oqsprovider in tests directory, specifically the
oqs_test_endecode.cfile. Consider the following (modified) version of this file:If I understand correctly, the function EVP_PKEY_private_check() is used to verify the private portion of an EVP_PKEY structure. Now in above code, the
OSSL_KEYMGMT_SELECT_PUBLIC_KEYselection is being used, which according to this link states that only public portion from the EVP_PKEY structure is considered. This means that after thedecode_EVP_PKEY_prov()function, the 'decoded_pkey' should contain only the public key.If I run the above code, I am getting success for private key verification of the '
decoded_pkey' using the functionEVP_PKEY_private_check(which should not be the case, because I only encoded the public portion of the keypair)I would be very thankful to be pointed in the right direction here. My goal is to encode only the public key portion of the keypair so that it can be sent to the other party for KEM encapsulation, but currently it seems like both public and private information is being encoded.
Beta Was this translation helpful? Give feedback.
All reactions