diff --git a/.circleci/config.yml b/.circleci/config.yml index c900afdb..63b84570 100644 --- a/.circleci/config.yml +++ b/.circleci/config.yml @@ -240,19 +240,6 @@ jobs: fi fi - check-clang-format: - docker: - - image: cimg/base:2022.12 - steps: - - run: - name: Install dependencies - command: sudo apt-get update && sudo apt-get install -y clang-format - - checkout - - run: - name: Check coding style using clang-format - command: | - find . -type f -and '(' -name '*.h' -or -name '*.c' -or -name '*.inc' ')' | xargs clang-format --dry-run --Werror - trigger-downstream-ci: docker: - image: cimg/base:2020.01 @@ -277,7 +264,6 @@ workflows: version: 2.1 build: jobs: - - check-clang-format - ubuntu: name: ubuntu-focal IMAGE: openquantumsafe/ci-ubuntu-focal-x86_64:latest diff --git a/.github/workflows/linux.yml b/.github/workflows/linux.yml index c1898500..d7643575 100644 --- a/.github/workflows/linux.yml +++ b/.github/workflows/linux.yml @@ -7,9 +7,26 @@ on: branches: [ "main" ] jobs: + check_clang_format: + name: "Coding style" + runs-on: ubuntu-latest + strategy: + fail-fast: false + container: + image: openquantumsafe/ci-ubuntu-jammy:latest + steps: + - name: Install dependencies + run: apt-get update && apt-get install -y clang-format + + - name: Checkout code + uses: actions/checkout@v2 + + - name: Check coding style using clang-format + run: find . -type f -and '(' -name '*.h' -or -name '*.c' -or -name '*.inc' ')' | xargs clang-format --dry-run --Werror linux_baseline: runs-on: ubuntu-latest + needs: [check_clang_format] strategy: fail-fast: false matrix: @@ -30,6 +47,7 @@ jobs: linux_intel: runs-on: ubuntu-latest + needs: [check_clang_format] strategy: fail-fast: false matrix: @@ -79,6 +97,7 @@ jobs: asan_linux_intel: name: "Security checks" runs-on: ubuntu-latest + needs: [check_clang_format] strategy: fail-fast: false container: @@ -154,6 +173,7 @@ jobs: linux_aarch64: name: "aarch64 cross-compilation" runs-on: ubuntu-latest + needs: [check_clang_format] strategy: fail-fast: false container: @@ -238,3 +258,4 @@ jobs: with: name: oqsprovider-aarch64 path: build/*.deb + diff --git a/.github/workflows/macos.yml b/.github/workflows/macos.yml index 7aaeaf2d..ded0beba 100644 --- a/.github/workflows/macos.yml +++ b/.github/workflows/macos.yml @@ -57,7 +57,7 @@ jobs: key: ${{ runner.os }}-openssl32 - name: build liboqs run: | - cmake -DOPENSSL_ROOT_DIR=../.localopenssl32 -DCMAKE_INSTALL_PREFIX=../.localliboqs ${{ matrix.params.oqsconfig }} -S . -B _build + cmake -DOPENSSL_ROOT_DIR=../.localopenssl32 -DCMAKE_INSTALL_PREFIX=../.localliboqs ${{ matrix.params.oqsconfig }} -S . -B _build cmake --build _build cmake --install _build working-directory: liboqs diff --git a/.github/workflows/standalone.yml b/.github/workflows/standalone.yml index 39b01457..9c0ee9a3 100644 --- a/.github/workflows/standalone.yml +++ b/.github/workflows/standalone.yml @@ -5,7 +5,7 @@ on: branches: [ '*' ] pull_request: branches: [ "main" ] - + jobs: standalone_macos_intel: diff --git a/.github/workflows/windows.yml b/.github/workflows/windows.yml index 56a5d1c4..cdf5c585 100644 --- a/.github/workflows/windows.yml +++ b/.github/workflows/windows.yml @@ -212,7 +212,7 @@ jobs: - arch: win64 oqsconfig: -DOQS_ALGS_ENABLED=STD osslconfig: no-shared no-fips VC-WIN64A - toolchain: + toolchain: - .CMake/toolchain_windows_amd64.cmake msarch: - x64 @@ -261,7 +261,7 @@ jobs: run: | cmake --version cmake -B build --toolchain ${{ matrix.toolchain }} . - cmake --build build + cmake --build build cmake --build build --target INSTALL working-directory: liboqs - name: prepare the OpenSSL build directory @@ -305,4 +305,4 @@ jobs: with: name: oqs-provider-msvc path: D:/a/oqs-provider/oqs-provider/_build/lib/oqsprovider.dll - +