Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strengthen signature verification failure tests #1999

Open
SWilson4 opened this issue Nov 19, 2024 · 2 comments
Open

Strengthen signature verification failure tests #1999

SWilson4 opened this issue Nov 19, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@SWilson4
Copy link
Member

For background, please see this discussion: #1919 (comment) and related issue #1995.

It may be desirable to modify or extend our signature tests to take into account "weaker" forgeries as well as specific security claims (EUF-CMA vs SUF-CMA).

@rtjk
Copy link
Contributor

rtjk commented Nov 26, 2024

If we wanted to thoroughly check trivial forgeries for SUF-CMA, instead of incrementing a single random byte we could have the test flip each bit of a signed message, one at a time, and expect a verification error. I made something similar to investigate #1995, would this be a welcome addition or is it out of scope?

@baentsch
Copy link
Member

would this be a welcome addition or is it out of scope?

any improvement on testing the quality of code in OQS is welcome!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Status: Todo
Development

No branches or pull requests

3 participants