Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Appveyor builds failing on main #1681

Closed
SWilson4 opened this issue Jan 31, 2024 · 1 comment · Fixed by #1682
Closed

Appveyor builds failing on main #1681

SWilson4 opened this issue Jan 31, 2024 · 1 comment · Fixed by #1682
Labels
platform-specific Issue related to a specific platform configuration; core team may not have required platform

Comments

@SWilson4
Copy link
Member

The daily AppVeyor builds have been failing for some time. I've manually re-triggered builds on older commits that passed originally, and now they fail too. For example: build 1 vs build 2. It looks to me like the only difference between the two environments is that the successful build used OpenSSL 3.1.1 and the failed build used OpenSSL 3.2.0.

I don't think it's a great use of our time trying to debug this, especially given that our GitHub Actions Windows tests are passing with no issues (and are set up to run on PRs). The GH CI builds all use MSVC 19, so the only reason I see to keep AppVeyor around is to support cygwin / msys2. Is this something we want to do?

Aside: The most recent AppVeyor tests are failing in a lot more places because I missed disabling the long KAT tests in AppVeyor in #1560... oops. These are expected to fail for Falcon-1024 for the time being.

Tagging @baentsch @christianpaquin for input since this came up in a previous meeting.

@SWilson4 SWilson4 added the platform-specific Issue related to a specific platform configuration; core team may not have required platform label Jan 31, 2024
@baentsch
Copy link
Member

baentsch commented Feb 1, 2024

so the only reason I see to keep AppVeyor around is to support cygwin / msys2. Is this something we want to do?

I'd argue the answer is encoded in PLATFORMS.md: No. Neither cygwin nor msys2 are documented there. If someone wants this they should speak up.

In addition, a certain subproject does (github-based) cygwin builds... So I'd vote for eliminating AppVeyor for good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
platform-specific Issue related to a specific platform configuration; core team may not have required platform
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants