Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve CI for macOS on Apple Silicon #1630

Closed
dstebila opened this issue Dec 14, 2023 · 10 comments · Fixed by #1709
Closed

Improve CI for macOS on Apple Silicon #1630

dstebila opened this issue Dec 14, 2023 · 10 comments · Fixed by #1709
Labels
enhancement New feature or request

Comments

@dstebila
Copy link
Member

Due to poor CI support this is currently a Tier 3 system according to our PLATFORMS.md document, but it should be better.

#1605 (comment)

@SWilson4
Copy link
Member

SWilson4 commented Feb 9, 2024

@dstebila @baentsch It looks it should now be feasible to use an M1 runner through GitHub actions: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source.

Edit to add: The M1 runner outperforms the Intel runner in a (very) limited oqs-provider test run: https://github.com/open-quantum-safe/oqs-provider/actions/runs/7846813573

@dstebila
Copy link
Member Author

@dstebila @baentsch It looks it should now be feasible to use an M1 runner through GitHub actions: https://github.blog/changelog/2024-01-30-github-actions-introducing-the-new-m1-macos-runner-available-to-open-source.

Edit to add: The M1 runner outperforms the Intel runner in a (very) limited oqs-provider test run: https://github.com/open-quantum-safe/oqs-provider/actions/runs/7846813573

It would be great to start using this and move away from our ad hoc solution involving one of our own machines.

@baentsch
Copy link
Member

It would be great to start using this and move away from our ad hoc solution involving one of our own machines.

We presently do that basically for profiling (in the process also testing). Indeed it would be nice to also do that on github (weekly run) if we decide to keep that sub project alive...

@SWilson4
Copy link
Member

SWilson4 commented Feb 13, 2024

Related to today's meeting: GitHub Actions does seem to have Arm runners, which are currently in private beta: https://github.blog/changelog/2023-10-30-accelerate-your-ci-cd-with-arm-based-hosted-runners-in-github-actions

A GitHub executive recently mentioned in the OQS Discord that they had helped to get LF projects additional GitHub features in the past—perhaps it's worth following up with them to see if we can get into the private beta?

@Martyrshot
Copy link
Member

Worth mentioning: Someone from github joined the pqca discord and offered to talk to the admins about getting extra features. Ry Jones responded saying that he would contact them once they are back in office, so it might be worth talking to Ry about.

@SWilson4
Copy link
Member

Worth mentioning: Someone from github joined the pqca discord and offered to talk to the admins about getting extra features. Ry Jones responded saying that he would contact them once they are back in office, so it might be worth talking to Ry about.

This is what I meant to convey, but I typed "GitHub" instead of "Discord" 🙊

@Martyrshot
Copy link
Member

Ah, sorry. I wasn't sure if it was on a github discussion or not so I was trying to link the two. Sorry about that @SWilson4!

@SWilson4
Copy link
Member

Ah, sorry. I wasn't sure if it was on a github discussion or not so I was trying to link the two. Sorry about that @SWilson4!

No, all good, I was just clarifying my comment so people wouldn't look for a non-existent GitHub discussion 😆 Thanks for pointing it out!

@planetf1
Copy link
Contributor

Apologies to jump in. 2nd class m1/arm can be a pain (including lack of containers etc). Had it in other projects. You may have this in hand, but if you need any help with this item I'm happy to help out. great news to see additional arm runners in addition to macos on m1.

@baentsch
Copy link
Member

I'm happy to help out.

That would be very welcome, Thanks! Please add ARM and M1 github runners! Ideally switching off the corresponding CCI tests at the same time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants