Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add APi for signatures with context string #270

Open
dstebila opened this issue Nov 19, 2024 · 0 comments · May be fixed by #272
Open

Add APi for signatures with context string #270

dstebila opened this issue Nov 19, 2024 · 0 comments · May be fixed by #272
Assignees
@SWilson4
Labels
enhancement New feature or request

Comments

@dstebila
Copy link
Member

Currently the signing and verification API within liboqs are as follows:

OQS_API OQS_STATUS OQS_SIG_sign(const OQS_SIG *sig, uint8_t *signature, 
    size_t *signature_len, const uint8_t *message, size_t message_len, 
    const uint8_t *secret_key);
OQS_API OQS_STATUS OQS_SIG_verify(const OQS_SIG *sig, const uint8_t *message, 
    size_t message_len, const uint8_t *signature, size_t signature_len, 
    const uint8_t *public_key);

The API that NIST has introduced in FIPS 204 for ML-DSA includes a context string of length ≥ 0.

open-quantum-safe/liboqs#1919 adds a new API for signing with a context string:

OQS_API OQS_STATUS OQS_SIG_sign_with_ctx_str(const OQS_SIG *sig, uint8_t *signature, 
    size_t *signature_len, const uint8_t *message, size_t message_len, const uint8_t *ctx_str, 
    size_t ctx_str_len, const uint8_t *secret_key);
OQS_API OQS_STATUS OQS_SIG_verify_with_ctx_str(const OQS_SIG *sig, const uint8_t *message, 
    size_t message_len, const uint8_t *signature, size_t signature_len, const uint8_t *ctx_str, 
    size_t ctx_str_len, const uint8_t *public_key);

This language wrapper will need to be updated to support the new API for signing/verifying with context string.

Note there is also a discussion in open-quantum-safe/liboqs#2001 about whether to deprecate the old API.
@dstebila dstebila added the enhancement New feature or request label Nov 19, 2024
@SWilson4 SWilson4 self-assigned this Dec 16, 2024
@SWilson4 SWilson4 linked a pull request Dec 17, 2024 that will close this issue
feat: Update to liboqs 0.12.0 #272
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@SWilson4 SWilson4

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Update to liboqs 0.12.0 open-quantum-safe/liboqs-rust
2 participants
@dstebila @SWilson4