-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V0.10.0 #80
Conversation
README.md
Outdated
providing post-quantum key encapsulation and signture mechanisms, respectively. | ||
Each must be instantiated with a string identifying one of mechanisms supported | ||
by liboqs; these can be enumerated using the `get_enabled_KEM_mechanisms()` and | ||
`get_enabled_sig_mechanisms()` functions. The files in `examples/` demonstrate |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Different capitalization KEM/sig?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For some "historical" reason I used KEM and "sig" across the wrappers, so it'll break the API if I rename it. Perhaps in a future version.
and [Michele Mosca](http://faculty.iqc.uwaterloo.ca/mmosca/) at the University of Waterloo. | ||
The Open Quantum Safe project is led by | ||
[Douglas Stebila](https://www.douglas.stebila.ca/research/) and | ||
[Michele Mosca](http://faculty.iqc.uwaterloo.ca/mmosca/) at the University of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No more. It's now an LF project :-(
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the "auto-install" feature, @vsoftco ! It looks "rough and ready" making me wonder whether it should be done together with the 0.10.0 release or be given some time to mature/be tested in "main" first (via separate PR ?). The rest LGTM apart from some nits (single comments).
Fix Windows auto install, refactoring
@baentsch Thanks for the review Michael! I've fix most of the issues, and also greatly simplified the auto install, which now installs liboqs in user's home directory. In addition, the wrapper installs the corresponding ver of liboqs, e.g. liboqs-python 0.10.0 installs liboqs-0.10.0. I believe now it's ready to be merged into 0.10.0. I'll test it a bit more then do the merge. Again, thanks! |
@baentsch All looks smooth, all tests pass, auto install is flawless on all platforms, no need for sudo anymore :) I'll merge this soon, and release the 0.10.0. Thanks! |
No description provided.