Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Register the singleton's nspace with the PMIx server #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bosilca
Copy link
Member

@bosilca bosilca commented Nov 14, 2024

Once we have created the necessary PRRTE infrastructure to support the singleton, we need to register that info with our internal PMIx server so it can be served to any requesting clients.

Signed-off-by: Ralph Castain [email protected]
(from upstream commit 89fdffe)

Once we have created the necessary PRRTE infrastructure
to support the singleton, we need to register that info
with our internal PMIx server so it can be served to
any requesting clients.

Signed-off-by: Ralph Castain <[email protected]>
(cherry picked from commit 89fdffe)
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

8f3060e: Register the singleton's nspace with the PMIx serv...

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: 89fdffe

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@janjust janjust requested review from janjust and hppritcha November 25, 2024 20:40
Copy link

Hello! The Git Commit Checker CI bot found a few problems with this PR:

8f3060e: Register the singleton's nspace with the PMIx serv...

  • check_cherry_pick: contains a cherry pick message that refers to a commit that exists, but is in an as-yet unmerged pull request: 89fdffe

Please fix these problems and, if necessary, force-push new commits back up to the PR branch. Thanks!

@hppritcha
Copy link
Member

if we merge this and update the ompi main prrte sha to include this we will need to advance pmix sha. That may lead to mpi4py failures however.

@rhc54
Copy link

rhc54 commented Nov 25, 2024

You cannot compile your PRRTE fork against PMIx upstream master - it is too out-of-sync. You'd have to switch back to upstream PRRTE.

@hppritcha
Copy link
Member

we will not do that until open-mpi/ompi#12906 pass mpi4py

@rhc54
Copy link

rhc54 commented Nov 25, 2024

we will not do that until open-mpi/ompi#12906 pass mpi4py

Understood and agreed - was only pointing out the problem. I'm working on it 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants