-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
hwloc: add latest_release.txt near latest_snapshop.txt #468
Conversation
@bwbarrett or @jsquyres Can you please review this? It works (manually tested inside OMPI 4.1 where there's currently a RC prerelease) but I am not sure all .htaccess changes are needed (the first one is). |
Some people want the latest release version number, not including release candidates. Refs Homebrew/homebrew-core#151735 Signed-off-by: Brice Goglin <[email protected]>
Signed-off-by: Brice Goglin <[email protected]>
<a href="../../software/hwloc/current/downloads/latest_release.txt"><tt>latest_release.txt</tt></a> link</b>. | ||
For the latest release or release candidate, rather use the | ||
<a href="../../software/hwloc/current/downloads/latest_snapshot.txt"><tt>latest_snapshot.txt</tt></a> link. | ||
For the latest on a specific series, replace "<tt>current</tt>" with "<tt>v2.9</tt>" in these links for instance. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you really want to hard-code a specific version here? (I know you're just carrying forward older text -- should we make this variadic somehow?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You mean replace "v2.9" with something like "" ?
In general, I don't care much. However, once 3.0 gets released, I may actually prefer hardwiring "v2.10" for people that cannot upgrade yet.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you're cool with it (the hard-coded v2.9
), then so am I. I just always ask when I see hard-coded version numbers, because they typically don't get updated until someone happens to notice that they're out of date (like now 😄).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, hahah! Your PHP got rendered as "", not:
<?php print($series_dir); ?>
Either way is fine with me. If you want to update the PR, cool. If you don't care, fine.
Some people want the latest release version number, not including release candidates.
Refs Homebrew/homebrew-core#151735