Skip to content
This repository has been archived by the owner on Jul 31, 2022. It is now read-only.

aggregator needs to retain logfiles when PR fails to pass jenkins clients tests. #1

Open
hppritcha opened this issue Apr 1, 2015 · 1 comment

Comments

@hppritcha
Copy link
Member

Per discussion on 4/1/15, it was decided at least for now that the jenkins aggregator will normally delete any logfiles associated with a PR if the jenkins clients report success. More specifically in this case, the logfiles will be deleted from the aggregators database once the PR has been closed.

In the case when one or more of the jenkins clints reported a failure, the results for the PR will be retained even after it has been closed.

If the aggregator's database grows to large using this approach, a more refined approach for retaining logfiles for failed cases will need to be considered.

@jsquyres
Copy link
Member

jsquyres commented Apr 1, 2015

Extra bonus points if, when the logfiles are deleted (e.g., for a successful build and the PR is closed), either:

  1. The aggregator somehow gets Github to delete the "details" link on the PR (i.e., so there's no dangling link left), or
  2. If the aggregator can't get Github to delete the "details" link, when someone clicks through to that dangling link, they get some kind of reasonable web page from the aggregator saying, "Sorry, the results for this build are no longer available, and you probably didn't care about them anyway..." (vs. a nasty/ugly 404 page).

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants