Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix fsdp weight reading error #3817

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

1921134176
Copy link

Fix fsdp weight reading error

Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.

Motivation

I used FSDP to train the model and saved the model weights in shards. However, during testing, there were errors in reading the weights, and it was found that the reason was that the test. py script omitted the judgment of the runner type..

Modification

Referring to the train.by script, a judgment of the runner type has been added to the test.by script.

BC-breaking (Optional)

Does the modification introduce changes that break the backward-compatibility of the downstream repos?
NO.

Use cases (Optional)

If this PR introduces a new feature, it is better to list some use cases here, and update the documentation.

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit test to ensure the correctness.
  3. If the modification has potential influence on downstream projects, this PR should be tested with downstream projects, like MMDet or MMDet3D.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

Fix fsdp weight reading error
@CLAassistant
Copy link

CLAassistant commented Nov 21, 2024

CLA assistant check
All committers have signed the CLA.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants