Added the ability to build a project with PyTorch 2.0. #2553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely, I added the flag -std=c++17 to extra_compile_args depending on the version of Torch.
|
|
hi, thanks for your PR. Could you sign the cla? |
|
You forget to import |
Thank you very much, import added. "12 workflows awaiting approval" |
irexyc
approved these changes
Nov 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
I use mmdeploy in my project.
Modification
Added the ability to build a project with PyTorch 2.0.
Namely, I added the flag -std=c++17 to extra_compile_args in setup.py depending on the version of Torch like mmcv setup.py.
https://github.com/open-mmlab/mmcv/blob/main/setup.py#L203