Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

export get_simcc_maximum for simcc #2449

Merged
merged 4 commits into from
Sep 28, 2023

Conversation

RunningLeon
Copy link
Collaborator

@RunningLeon RunningLeon commented Sep 20, 2023

Motivation

export get_simcc_maximum for simcc and rtmpose models.

Modification

Support torch2onnx with post-processing get_simcc_maximum for onnxruntime and tensorrt backend.

  • Note that ncnn backend is not supported in this PR.

BC-breaking (Optional)

None

Use cases (Optional)

Add the following records to deploy config to enable exporting get_simcc_maximum

codebase_config = dict(
    export_postprocess=True  # export get_simcc_maximum
)

Checklist

  1. Pre-commit or other linting tools are used to fix the potential lint issues.
  2. The modification is covered by complete unit tests. If not, please add more unit tests to ensure the correctness.
  3. If the modification has a dependency on downstream projects of a newer version, this PR should be tested with all supported versions of downstream projects.
  4. The documentation has been modified accordingly, like docstring or example tutorials.

@RunningLeon RunningLeon changed the title update simcc [WIP]: update simcc Sep 20, 2023
@codecov
Copy link

codecov bot commented Sep 20, 2023

Codecov Report

Attention: 30 lines in your changes are missing coverage. Please review.

Files Coverage Δ
mmdeploy/codebase/mmpose/codecs/__init__.py 100.00% <100.00%> (ø)
mmdeploy/codebase/mmpose/models/heads/__init__.py 100.00% <100.00%> (ø)
mmdeploy/codebase/mmpose/deploy/pose_detection.py 72.19% <33.33%> (-0.79%) ⬇️
...loy/codebase/mmpose/deploy/pose_detection_model.py 54.26% <14.28%> (-1.39%) ⬇️
...mdeploy/codebase/mmpose/models/heads/simcc_head.py 37.50% <37.50%> (ø)
mmdeploy/codebase/mmpose/codecs/post_processing.py 14.28% <14.28%> (ø)

📢 Thoughts on this report? Let us know!.

@RunningLeon RunningLeon changed the title [WIP]: update simcc export get_simcc_maximum for simcc Sep 26, 2023
@RunningLeon RunningLeon added enhancement New feature or request and removed WIP labels Sep 26, 2023
@RunningLeon
Copy link
Collaborator Author

@Tau-J hi, could you take a look at this PR? And may let the user of this request have a try.

@RunningLeon RunningLeon merged commit 4cf0f92 into open-mmlab:main Sep 28, 2023
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants