Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RectangularZone combined with InterZonalAirFlow.TwoPorts #1247

Closed
kldjonge opened this issue Jan 24, 2022 · 4 comments
Closed

RectangularZone combined with InterZonalAirFlow.TwoPorts #1247

kldjonge opened this issue Jan 24, 2022 · 4 comments

Comments

@kldjonge
Copy link
Contributor

While working on #1246, I noticed that the RectangularZone combined with interZonalAirFlowType=IDEAS.BoundaryConditions.Types.InterZonalAirFlow.TwoPorts doesn't work. I assumed it had something to do with my additions but apparently it is present in the current version of IDEAS as well.

@Mathadon
Copy link
Member

@kldjonge I think we just didn't implement it properly the first time.

@jelgerjansen
Copy link
Contributor

@Mathadon, @kldjonge #1246 is already merged, but apparently there were still issues. However, #1296 is still open and seems to relate to the same feature (discussed in issue #1244).
Can we close this issue and leave #1244 open?

@Mathadon
Copy link
Member

Mathadon commented Apr 3, 2023

@kldjonge I think this can be closed?

@kldjonge
Copy link
Contributor Author

kldjonge commented Apr 3, 2023

Yes, for now this issue is fixed. (I say 'for now' because the actual verification with CONTAM is not finalised). But in terms of cleaning up issues it can be closed.

@kldjonge kldjonge closed this as completed Apr 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants