fix(DOMA-10698): fixed some cases of unitName parsing #5500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoviazin
added
👶 small
sitozzz
reviewed
Nov 22, 2024
Comment on lines
-5
to
+9
| warehouse: ['помещение', 'подвал', 'помещ', 'пом', 'кл', 'кладовка', 'кладовая', 'нп'], | ||
| warehouse: ['помещение', 'подвал', 'помещ', 'пом', 'кл', 'кладовка', 'кладовая', 'нп', 'клад'], | ||
| flat: ['квартира', 'кв', 'комн'], | ||
| } | ||
|
|
||
| const HOUSE_IDENTIFIERS = 'д|уч|дом|участок|двлд' | ||
| const HOUSE_IDENTIFIERS = 'д|уч|дом|участок|двлд|домовладение' |
There was a problem hiding this comment.
Don't we think to make that configurable through environment?
dkoviazin
force-pushed
the
fix/condo/DOMA-10698/fixes_in_unit_name_parsing
branch
from
25077f3
to
dc05336
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For example
unitName "НП10" - before was cleared to warehouse 10, now it will be warehouse НП10
unitName "НП 10" - will still be: warehouse 10
unitName "клад. 10" - was converted to "ад. 10"