fix(condo): no more useless react warnings

[pahaz]

🥳🥳🥳

[sitozzz]

Do we really need note inside client-side part?

[SavelevMatthew]

Why do you suppress all warning on the entire body? This means you cannot catch it in development mode. You should fix your browser extensions instead, shouldn't you?

[pahaz]

Why do you suppress all warning on the entire body?

In reality, we do not have and will never have any attributes in the body. However, this warning is quite common and will always appear, negatively impacting the developer experience (DX) for external contributions and local development.

I don't see a significant issue with adding this to the body and html since we won't be passing any attributes there. This approach would also help avoid unnecessary distractions from additional warnings. I would prioritize DX in this case, as attributes are often passed in the body. I don't perceive any substantial risks of accidental errors arising from this. Currently, I've had to address more than four warnings because everyone is accustomed to their presence. Therefore, I want to enhance the local development experience so that even warnings from third-party extensions do not divert attention.

[SavelevMatthew]

Why do you suppress all warning on the entire body?

In reality, we do not have and will never have any attributes in the body. However, this warning is quite common and will always appear, negatively impacting the developer experience (DX) for external contributions and local development.

I don't see a significant issue with adding this to the body and html since we won't be passing any attributes there. This approach would also help avoid unnecessary distractions from additional warnings. I would prioritize DX in this case, as attributes are often passed in the body. I don't perceive any substantial risks of accidental errors arising from this. Currently, I've had to address more than four warnings because everyone is accustomed to their presence. Therefore, I want to enhance the local development experience so that even warnings from third-party extensions do not divert attention.

Does this only affects body? Because I'm worried about its behaviour, if hydration error occurred in children, will it be thrown?

[SavelevMatthew]

According to react docs, it will suppress on children's too... 🤔

I've found out, that not deep check, but I'm wondering how its work on this top level

[sonarcloud]

Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud