Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possible memory leak #18

Closed
yusiwen opened this issue Aug 31, 2018 · 3 comments
Closed

Possible memory leak #18

yusiwen opened this issue Aug 31, 2018 · 3 comments

Comments

@yusiwen
Copy link
Contributor

yusiwen commented Aug 31, 2018

In xml.c , function xml_easy_child()

lien 835-837:

} else {
  return 0;
}

It should be:

} else {
  va_end(arguments);
  return 0;
}

And line 843 - 845:

if (!next) {
  return 0;
}

It should be:

if (!next) {
  va_end(arguments);
  return 0;
}
@ooxi
Copy link
Owner

ooxi commented Aug 31, 2018

Yes, you are right, good catch! Do you want to prepare a pull request with the fix?

yusiwen added a commit to yusiwen/xml.c that referenced this issue Aug 31, 2018
@yusiwen
Copy link
Contributor Author

yusiwen commented Aug 31, 2018

OK, I've just released a pull-request, plz check it.

@ooxi ooxi closed this as completed in #19 Aug 31, 2018
ooxi pushed a commit that referenced this issue Aug 31, 2018
@ooxi
Copy link
Owner

ooxi commented Aug 31, 2018

Great work, thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants