strange multiline if alignment

[trylika]

according to strictstandart, it suggests to aling multiline if like that:

            if (!isset($suggestion)
                || (isset($suggestion)
                && ($suggestion->status == SuggestionDocument::STATUS_NEW
                || $suggestion->status == SuggestionDocument::STATUS_NO_MATCHES))
            ) 

it doesn't look natural because of complexity of if structure. Maybe it should be aligned differently?

[tautrimas]

You are right. Proper formatting should look like this:

        if (!isset($suggestion)
            || (isset($suggestion)
                && ($suggestion->status == SuggestionDocument::STATUS_NEW
                    || $suggestion->status == SuggestionDocument::STATUS_NO_MATCHES))
        ) {

Or even better like this:

        if (!isset($suggestion)
            || (
                isset($suggestion)
                && (
                    $suggestion->status == SuggestionDocument::STATUS_NEW
                    || $suggestion->status == SuggestionDocument::STATUS_NO_MATCHES
                )
            )
        ) {

In the latter variant, ONGR Strict Standard (Squiz standard) disallows hierarchical indentation and expects every line to begin with boolean operator.

1. These rules should be either disabled, or programmed to only disallow boolean operator at the end of line.
2. Incorrect forcing of hierarchical indentation should be fixed or disabled.