Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NullPointerException in some cases #22

Open
kkv4all opened this issue Mar 6, 2020 · 1 comment
Open

NullPointerException in some cases #22

kkv4all opened this issue Mar 6, 2020 · 1 comment

Comments

@kkv4all
Copy link

kkv4all commented Mar 6, 2020

In some cases the code getUserData("lineNumber") is returning null and throwing NullPointerException as toString() is called like below
idElement.getUserData("lineNumber").toString();
I have fixed it in by replacing it by type casting like below
(String)codeElement.getUserData("lineNumber")

Also looking forward to contribute in this Repo. let me know if it is possible

Please refer the permalink below:

code.setLineNumber(codeElement.getUserData("lineNumber").toString());

@drbgfc
Copy link
Contributor

drbgfc commented Mar 6, 2020

Hi Kushal,

Thanks for finding the NPE. There's no reason why you can't make a PR, and then one of use can reproduce the issue, and decide if the solution is appropriate, and merge. So in effect you can certainly contribute. Since this particular project is not updated often, I wouldn't expect even large ideas to have conflicts. At the same time though, I can't guarantee things will be implemented/merged quickly.
We only have one branch on this project, so forking master, making the update, and making a PR from your master to ours would be all that is required.

Thanks,
Dan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants