Implement an interface from fetching job metrics from InfluxDB #663
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #663 +/- ##
==========================================
+ Coverage 92.57% 92.74% +0.17%
==========================================
Files 85 86 +1
Lines 4483 4588 +105
==========================================
+ Hits 4150 4255 +105
Misses 333 333
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…fluxDB and send it to the API
matheushent
force-pushed
the
matheushent/PENG-2457--job-metric-collection--agent
branch
from
01fb385
to
71d3ffd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
This PR implement the necessary code in the Jobbergate Agent and its Snap to enable job metric collection from InfluxDB.
The implementation involves a settings parameter which is used for connecting to InfluxDB. The logic happens during the
active_submissions_tasktask. If any part of the upload of metrics of an active job submission fails, it won't interrupt the execution.Once fetched the metrics for an active job submission, the agent sends to the API.
Why
Provide insights regarding jobs through the API.
Task: https://sharing.clickup.com/t/h/c/18022949/PENG-2457/BU7UOA63B936N27Peer Review
Please follow the upstream omnivector documentation concerning
peer-review guidelines.