-
-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
β Outdoor Temperature and Energy Consumption - Home Assistant Sensor #215
Draft
omerfaruk-aran
wants to merge
16
commits into
main
Choose a base branch
from
add-outdoor-sensors
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
β¦rotocol to match outdoor_temperature naming in code and configuration.
β¦rotocol to match outdoor_temperature naming in code and configuration.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
π Description
What does this Pull Request do?
This PR adds outdoor temperature and energy sensors to enhance the Samsung HVAC system's integration with ESPHome. Additionally, significant code optimizations were performed to improve performance and maintainability.
β¨ Key Changes
Outdoor Temperature
sensor to track the temperature reported by the outdoor unit.Outdoor Instantaneous Power
sensor to monitor power usage in real-time.Outdoor Cumulative Energy
sensor to track total energy consumption.π Related Issues
Fixes: #214, #108
Related: discussions
β Checklist
Please ensure the following before submitting your PR:
π Environment Information
π’ Versions
𧩠Devices
π§ͺ Test Plan
How were these changes tested?
π Logs
π οΈ YAML Configuration