Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github workflow passes even if tests fail. #98

Open
dominikl opened this issue Sep 14, 2021 · 5 comments
Open

Github workflow passes even if tests fail. #98

dominikl opened this issue Sep 14, 2021 · 5 comments

Comments

@dominikl
Copy link
Member

For now the output has to be check manually, workflow passes despite [ FAIL 1 | WARN 0 | SKIP 0 | PASS 157 ] .

@jburel
Copy link
Member

jburel commented Sep 14, 2021

══ Results ═════════════════════════════════════════════════════════════════════
Duration: 14.6 s

[ FAIL 0 | WARN 0 | SKIP 0 | PASS 160 ]

in #96
Where did you see the failure?

@dominikl
Copy link
Member Author

Can you see previous builds? It was the build before commit 1c545ad .

@dominikl
Copy link
Member Author

@jburel
Copy link
Member

jburel commented Sep 15, 2021

This is worrying. Basically test infra does not report the test failure

@jburel
Copy link
Member

jburel commented Sep 15, 2021

After a big of digging, the problem comes from the fact that the output of devtools::test() is never checked (see runtest file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants