Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plate loading for wells with varying zyx dimensions #240

Open
jluethi opened this issue Jan 19, 2023 · 0 comments
Open

Plate loading for wells with varying zyx dimensions #240

jluethi opened this issue Jan 19, 2023 · 0 comments

Comments

@jluethi
Copy link

jluethi commented Jan 19, 2023

Currently, the plate loading assumes all wells have the same dimensions in zyx and fails in different ways when this is not the case.

For example, if the wells have a different number of Z planes, it tries to load the number of z planes from the first well for each well. If all other wells have at least as many z planes

When wells have different xy sizes, in my experience what happens is that it just doesn't load anything, but also doesn't throw an error message.

The source of that is that the current plate loading gets the information about well layouts exclusively from the first well, see

well_zarr = self.zarr.create(self.well_paths[0])

This has performance benefits it the assumption holds true (not having to look at the metadata for each well). But we have more and more use-cases where these assumptions don't hold anymore. Many 3D HCS plates have different number of Z planes per well for us. When saving whole wells as single images (see ome/ngff#137), the xy dimension can vary in some use cases etc.

I'm providing a draft PR to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant