Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Github Page's style shouldn't be part of the styleguide itself #36

Open
arielj opened this issue Oct 30, 2020 · 0 comments
Open

Github Page's style shouldn't be part of the styleguide itself #36

arielj opened this issue Oct 30, 2020 · 0 comments

Comments

@arielj
Copy link
Member

arielj commented Oct 30, 2020

We are including all this CSS as a part of the styleguide https://github.com/ombulabs/styleguide/blob/gh-pages/vendor/assets/stylesheets/ombulabs/styleguide/5-pages/_styleguide.scss

This is specific for the github page and it's not needed for projects using the styleguide, we should move this to a static file so it doesn't bloat the CSS.

Also, there's too much custom style https://github.com/ombulabs/styleguide/blob/gh-pages/vendor/assets/stylesheets/ombulabs/styleguide/5-pages/_styleguide.scss#L93. Most of the style should come from the styleguide itself and should need minimal tweaks, if we need to add custom style for the styleguide to look good it means the original style does not look good probably.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

1 participant