Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Using aiologger in favor of python-json-logger #31

Open
diogommartins opened this issue Jun 25, 2020 · 2 comments
Open

Using aiologger in favor of python-json-logger #31

diogommartins opened this issue Jun 25, 2020 · 2 comments
Labels
enhancement New feature or request

Comments

@diogommartins
Copy link

diogommartins commented Jun 25, 2020

Motivations:

  1. Since BarterDude depends on async-worker, BarterDude already depends on aiologger, which means that the change won't add a new dependency. Instead, we'll be removing one!
  2. It will give BarterDude an easy performance boost, contributing to it's fully async design! (It's an old post, but a more detailed explanation can be found here)
  3. It has a built-in JSON logger, and it's a well documented and pretty straightforward to integrate with the project. Eg.: aiologger usage in asyncworker

Do you guys think that it's ok if I submit a PR with the changes need to use aiologger instead of python-json-logger?

@diogommartins diogommartins added the enhancement New feature or request label Jun 25, 2020
@dmvieira
Copy link
Contributor

Please yes! \o/

@gligneul
Copy link
Contributor

That would be great! As I said, the main problem that we encountered was capturing the logs in tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants